681

GOD DAMMIT STEVEN! NOT AGAIN! (lemmy.world)

submitted 7 months ago by Maven@lemmy.world to c/programmer_humor@programming.dev

72 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[-] xmunk@sh.itjust.works 139 points 7 months ago

You already stopped Steven in a prior commit.

Also, if this is an organization setting, I'm extremely disappointed in your PR review process. If someone is committing vendor code to the repo someone else should reject the pull.

[-] Cqrd@lemmy.dbzer0.com 106 points 7 months ago

What if I told you a lot of companies don't have solid review requirement processes? Some barely use version control at all

[-] xmunk@sh.itjust.works 32 points 7 months ago

Sure, I understand... but if you're at one of those companies you should introduce it.

[-] FizzyOrange@programming.dev 27 points 7 months ago

Yeah... Usually if you join a company with bad practices it's because the people who already work there don't want to do things properly. They tend to not react well to the new guy telling them what they're doing wrong.

Only really feasible if you're the boss, or you have an unreasonable amount of patience.

[-] frezik@midwest.social 3 points 7 months ago

Usually, the boss (or people above the boss) are the one's stopping it. Engineers know what the solution is. They may still resent the new guy saying it, though, because they've been through this fight already and are tired.