How is my Python code? (raw.githubusercontent.com)

submitted 1 day ago* (last edited 1 day ago) by the_citizen@lemmy.world to c/python@programming.dev

20 comments fedilink hide all child comments

I don't know if it's the true place to ask, apologizing if not. I started to python one and half week ago. So I'm still beginner.

I made a terminal based weather application with python. What do you think about the code, is it good enough? I mean is it professional enough and how can I make the same functions with more less code?

Here's the main file (I also added it as url to post): https://raw.githubusercontent.com/TheCitizenOne/openweather/refs/heads/main/openweather.py
Here's the config.json file: https://raw.githubusercontent.com/TheCitizenOne/openweather/refs/heads/main/config.json

you are viewing a single comment's thread
view the rest of the comments

[-] KindaABigDyl@programming.dev 11 points 1 day ago

You appear to be afraid of spaces. Everything is cramped together.

Just bc you don't have to put a space after colons or after equals and commas and whatnot doesn't mean you shouldn't

Don't be afraid of spaces.

They make it easier for you to read your code when you come back later

[-] the_citizen@lemmy.world 1 points 16 hours ago

I revised the code. Added some spaces and comments for better readability. Hope it's better now.

[-] FizzyOrange@programming.dev 1 points 8 hours ago

Instead you should just use an autoformatter. Black is good. Ruff is probably good too but I don't have a lot of experience with it. YAPF is not good; don't use it.