68
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
this post was submitted on 17 Sep 2023
68 points (100.0% liked)
Free and Open Source Software
17550 readers
171 users here now
If it's free and open source and it's also software, it can be discussed here. Subcommunity of Technology.
This community's icon was made by Aaron Schneider, under the CC-BY-NC-SA 4.0 license.
founded 2 years ago
MODERATORS
Rather if they get merged without edits.
I've seen even minor changes without flawed technique or style being discussed and changed for days before getting merged.
But it's also an excellent way to learn from pros. If the PR is worth it, they will spend the time for review and work with you until you fixed everything.
Eh, excellent code still gets discussed. Your approach might be unique and they haven't thought of it before. Or you may have perfectly suitable code, but it doesn't consider other parts of the project that you're not familiar with. Discussion isn't an indication of bad code, unless the only thing being discussed are mistakes.
That would be amazing, when your submission cause to improve the entire code base quality!