185
I just made my first Lemmy PR
(github.com)
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
this post was submitted on 08 Jul 2023
185 points (97.9% liked)
Technology
59414 readers
1164 users here now
This is a most excellent place for technology news and articles.
Our Rules
- Follow the lemmy.world rules.
- Only tech related content.
- Be excellent to each another!
- Mod approved content bots can post up to 10 articles per day.
- Threads asking for personal tech support may be deleted.
- Politics threads may be removed.
- No memes allowed as posts, OK to post as comments.
- Only approved bots from the list below, to ask if your bot can be added please contact us.
- Check for duplicates before posting, duplicates may be removed
Approved Bots
founded 1 year ago
MODERATORS
Not a bad idea! The attack vector issue they mention in the PR comments is valid, though. Not displaying those errors gives an attacker no confirmation that a user whose account they're trying to attack exists, if they're trying known used passwords. But good on you doing what you can to contribute to the project!
There should be an error, but it shouldn't say whether it was the email or password that was wrong.
~~An attacker would still know the account exists, and they would know the password did not match.~~
~~Or you're assuring them that specific password is used by some account, just not this one. Which is even worse.~~
Read the comment you're responding to, again. Nothing about their suggestion leads to either of these scenarios.
Right, I misread "shouldn't" for "should".