734
Merge then review (programming.dev)
submitted 2 years ago* (last edited 2 years ago) by agilob@programming.dev to c/programmer_humor@programming.dev

Move fast and break things.
Merge vulnerabilities.
Double the work.
Merge code without tests.
Anything, but don't let code become stale.

you are viewing a single comment's thread
view the rest of the comments
[-] Deifyed@lemmy.ml 4 points 2 years ago

I kind of with the sentiment. Review pre merge though, but only block the merge if there are serious faults. Otherwise, merge the code and have the author address issues after the merge. Get the value to production

[-] zalgotext@sh.itjust.works 1 points 2 years ago

Get the value to production

Ugh, not this SAFe Agile (tm) cultist bullshit. The "value" is working, bug free code, which you get when you put it through review and QA before it gets to production.

[-] Deifyed@lemmy.ml 1 points 2 years ago

There's often features and bug fixes worth more than the ones introduced in the PR. I've yet to see bug free code just because it's went through review and QA.

[-] zalgotext@sh.itjust.works 1 points 2 years ago

Surely you've seen bugs caught because code went through review and QA though. Those are bugs that would go into production if following the "advice" in this post.

[-] Deifyed@lemmy.ml 1 points 2 years ago

I'm saying identify the bugs through review, and fix them. Just do it in a new PR unless they are critical

load more comments (2 replies)
load more comments (12 replies)
this post was submitted on 14 Nov 2023
734 points (97.1% liked)

Programmer Humor

24790 readers
710 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 2 years ago
MODERATORS