I use the iCloud Photo Library, and seems worthwhile to me, though my photo library isn’t huge and has lots of stupid work pics. Frees up my phone storage, still have access anywhere I’ve got internet access. Big thing to me though is backups, iCloud is my really essential data, e-mails, contacts, family photos. That gets automatically synced up to iCloud, back down to my iMac, and that iMac gets backed up to my UnRaid server and a Time Capsule. So without any input from me, all my photos get backed up independently, with redundancy and versioning as well as to the cloud. That’s a pretty neat system to me.