A large portion of the us economy functions most effectively during a war effort.

the last time this was true, it was only true because the America government had gone into a planned economy for WW2

Im failing to see how its bad to sell old stockpiles for big bucks and replenish with more advanced weaponry.

we already did that, that's where the Ukraine aid came from, we don't got much more to sell off

Foreign policy is also questionable considering nearly every direct ally of the US is selling weapons to israel in one form or the other.

not to such a degree, also Israel is one of the big arms producers, if you exclude military aid from the US, they have been selling more than they have bought

The west benefits heavily from a destabilized Middle East.

how? higher oil prices? that's a detriment to the "western" economies and a boon to nations like SA, RU, etc... that's why Russia has been trying to increase the oil prices, because they know it will harm western economies