454

Ventoy source code contains some unknown BLOBs, still no word on the issue from the dev after months (github.com)

submitted 2 months ago by SatyrSack@lemmy.one to c/opensource@lemmy.ml

128 comments fedilink hide all child comments

I had no idea this issue had been identified. While I find this tool very useful, the project is seeming rather questionable to me now.

you are viewing a single comment's thread
view the rest of the comments

[-] Antagnostic@lemmy.world 219 points 2 months ago* (last edited 2 months ago)

I was bored at work one day. I decided to put a nyan cat easter egg in my company's app. If at the loading progress bar screen you typed NYAN it would turn the progress bar into a rainbow being created by a little nyan cat while playing the nyan cat song. The mp3 (inconspicuously renamed without the extension) doubled our build size. No one batted an eye cause no one paid attention to the build size much.

Fast forward 5 years later, at a different job, I get a phone call from the old boss. Do you happen to know anything about this nyan cat file we found?

I had no idea what he was talking about.

[-] fmstrat@lemmy.nowsci.com 64 points 2 months ago

Years and years ago I worked on a project where the logo was the outline of a head and an inward swirl for the brain.

For the website, if you held your mouse over it for 9 seconds, it would spin and flush. No one ever found that one that I know of.

[-] derpgon@programming.dev 8 points 2 months ago

Should've included that in your FE analytics.

[-] SynopsisTantilize@lemm.ee 30 points 2 months ago

10/10

[-] delirious_owl@discuss.online 26 points 2 months ago

Aaaand thats why all commits should be signed with your pgp key

[-] kautau@lemmy.world 11 points 2 months ago

It sounds like they weren’t using any form of version control, so that’s definitely on them at this point

[-] Alexstarfire@lemmy.world 18 points 2 months ago

What makes you say that? To me, it sounds like that's what they do have cause they tracked the change back to him. The commit message obviously said nothing about the file.

[-] kautau@lemmy.world 5 points 2 months ago

Ah I could see that. I took it as them not knowing where the file came from at all, so they’re just asking all the devs who would have had access at that point, which is why it was “hey do you know anything about this file?” and not “is there a specific reason you committed this file to the build?”

[-] Alexstarfire@lemmy.world 6 points 2 months ago

You think they'd call up devs who left them just to ask if they happen to know about a random file?

[-] kautau@lemmy.world 1 points 2 months ago

You think they’d call up devs who left them just to ask if they happen to know about a random file?

I mean, that’s what op said happened. Literally with the verbiage of “file we found” and not “file you committed”

[-] Alexstarfire@lemmy.world 1 points 2 months ago* (last edited 2 months ago)

I did mean random devs, not the dev they tracked down that made the change.

[-] kautau@lemmy.world 1 points 2 months ago* (last edited 2 months ago)

Right, I based it on an estimate on the size of the company and how many devs they’ve had. But if a 7MB file doubled their build size and nobody noticed for 5 years, it likely wasn’t code reviewed or committed and rather just added somewhere, It’d be my guess that it’s a pretty small team, and if they’re willing to call anyone at this point anyway as they only have a few devs, and not just remove the file, they’re probably unsure on if it serves any sort of point, which usually would be clear in a commit or PR