Hi,
This post has comments : https://jlai.lu/post/26123233
But when asking the API : https://jlai.lu/api/v3/comment/list?post_id=26123233&sort=Old
An empty array is returned.
Why ?
Thanks
Is this why I don’t see a lot of comments on Voyager, and what’s the fix there?
It might be, yes : https://github.com/aeharding/voyager/blob/main/src/routes/pages/shared/CommentsPage.tsx#L41
As mentioned by @cypherpunks@lemmy.ml, the solution is to add type_=All in query parameters.
From the Voyager app's source code, it seems like the value is undefined by default.
I think replacing this by All could fix the issue. But, I have no experience in that app's dev stack, so I can't be sure.
Therefore, I'd suggest submitting a GitHub issue showing 2 screenshots : of the same post, one on Voyager, the other one on another app, where the former shows less comments than the latter. Indicate that replacing undefined with All might fix the issue.
If the maintainer(s) reproduce and confirm, they'll push the fix.
If I was more confident, I'd directly make a PR, but I'm not.
Looking at the network tab while loading a thread, I see you need to include type_=All.
(lemmy-ui sends other parameters too but your example URL works for me with just tyoe_=All added.)
Thanks.
Now, why isn't that required for an older post ?
For example : https://lemmy.world/api/v3/comment/list?post_id=5&sort=Old
Read the API docs for what type means: https://join-lemmy.org/lemmy-js-client-docs/v0.19/classes/LemmyHttp.html#getComments
i'm guessing it might have something to do with the fact that jlai.lu is configured to default to the Local view while lemmy.world defaults to All
Interesting, thanks !
Support / questions about Lemmy.