Toolbar buttons should scroll to top on second tap (lemmy.world)

submitted 1 year ago* (last edited 1 year ago) by reddig33@lemmy.world to c/mlemapp@lemmy.ml

7 comments fedilink hide all child comments

For UI consistency, tapping the Feed button after you’re already in the Feed View should scroll to the top of the feed. That’s what similar apps do (like tapping the News button in Apple News).

If you’re worried about accidental taps, pressing it a second time should take you back to where you were in the feed.

The other toolbar buttons should work similarly. If you’re in the Inbox and you tap a comment, tapping Inbox should take you back to the main inbox. Tapping Inbox when you’re already in the inbox should scroll to the top of the Inbox (if you’re not there already).

top 7 comments

sorted by: hot top controversial new old

[-] ericbandrews@lemmy.ml 8 points 1 year ago

We've been working on it. A simple tap to jump to the top is pretty easy--things get tricky when you start adding complications like "jump back into the feed" or "navigate up a level," which require a more sophisticated architecture from the ground up. It is in active development, though, so we hope to have a prototype out soon enough.

[-] ahti@lemmy.world 4 points 1 year ago

I've just had the quickest of glances through the code. Is the gesture for opening the user switcher the only reason for reimplementing the tab bar? It sound's like you're rebuilding a lot of functionality that you get for free (iirc) with the native tab bar.

[-] SideshowBoz@lemmy.world 1 points 1 year ago

Unfortunately the system (SwiftUI) tab bar doesn’t come with this behaviour for some reason.

[-] haukesomm@feddit.de 2 points 1 year ago* (last edited 1 year ago)

I don't remember who wrote this, but a while ago some team member stated in this sub they had ~merged a PR~ a PR in the works that implements the described behavior. Perhaps there are other issues that emerged from this?

Edit: Clarification based on reply

[-] SideshowBoz@lemmy.world 3 points 1 year ago

Yea! There’s a draft PR that I left sitting around waiting for some 0.19 lemmy changes and also because the feature was triggering some undesirable performance issues not related to the tab bar itself.

Tbh it’s gotten faster just by building against iOS 17, I’m probably going to finish it up and merge it in since so many of us want this 🙈

[-] haukesomm@feddit.de 2 points 1 year ago

No worries, thanks for taking care of this and the explanation! :-) I certainly did not intend to complain in any way since I didn't even have time to look into the GitHub PRs myself

[-] SideshowBoz@lemmy.world 2 points 1 year ago

You good :p Would appreciate feedback when feature makes it out in the wild 🤓

this post was submitted on 03 Nov 2023

32 points (97.1% liked)

Mlem for Lemmy

5379 readers

1 users here now

Official community for Mlem, a free and open-source iOS Lemmy client.

Rules

Keep it civil.
This is a forum for discussion about Mlem. We welcome a degree of general chatter, but anything not related to Mlem may be removed at moderator discretion. This is not a forum for iPhone/Android debate. Posts and comments saying nothing but "iOS bad/I use Android" will be removed as off-topic.
We welcome constructive criticism, but ask that it be both precise and polite.

FAQ

When will insert feature here be implemented?
- Check our issue board--if there isn't an issue open for the feature you want, feel free to open an issue or make post! Just remember that devs are people too--we're doing this for free in our spare time, and building a quality app takes a lot of patient work.
Is Mlem available for Android?
- No. Mlem is written using SwiftUI, which is not currently supported on Android. If such support becomes available, we will look into bringing Mlem to our Android friends.
How do I join the beta?
- We are currently testing our new 2.0 codebase on TestFlight. We have two beta groups: a weekly group that receives the current state of our development branch every week, and a stable group that receives a curated pre-release build at the end of each development cycle.
- Join the weekly beta
- Join the stable beta
How do I join the dev team?
- Head over to our recruitment channel, or go straight to our GitHub and read CONTRIBUTING.md to get started.

Download Mlem for iOS

GitHub

Website

Donate to Mlem

founded 2 years ago

MODERATORS

ericbandrews@lemmy.ml

Kronusdark@lemmy.world