732
Merge then review (programming.dev)
submitted 1 year ago* (last edited 1 year ago) by agilob@programming.dev to c/programmer_humor@programming.dev

Move fast and break things.
Merge vulnerabilities.
Double the work.
Merge code without tests.
Anything, but don't let code become stale.

(page 3) 48 comments
sorted by: hot top controversial new old
[-] halvo317@sh.itjust.works 3 points 1 year ago

You guys review?

[-] Space_Racer@lemm.ee 3 points 1 year ago

As a SOC auditor you programmers are going to make me scream at the exceptions you guys cause.

[-] Devi@beehaw.org 2 points 1 year ago

This explains what is going on a facebook.

[-] petrescatraian@libranet.de 2 points 1 year ago

@agilob code is like wine. You let it out in the cold and it gets better over time by itself.

It can work if you have a test zone and only a small amount of people work on a given code base.

Also checks to ensure the code compiles and tests pass before merging, as some quality gateway.

[-] Skates@feddit.nl 1 points 1 year ago* (last edited 1 year ago)

That's nice but it goes against our quality standards and the international quality standards we are charging the client extra for adhering to, the line you're trying to merge into is stability and needs CCB approval for the merge, and the client has specifically requested only showstopper-level bugs be addressed for stability lines. You know what, I have neither the time nor the crayons to properly explain this to you, a consultant that supposedly knows the business. Pack your shit, you're gonna have a wonderful time posting this crap on LinkedIn instead. #gitshiton

2 days before, at Pete Hurrd former job

[-] Blackthorn@programming.dev 1 points 1 year ago

Probably unpopular opinion, but peer reviews are overrated. If coders are good AND know the project, the only thing you can do in a PR is nitpicking. They are more useful for open source collaborators because you want to double-check their code fits with the current architecture. But people here are reacting as if peer reviews could actually spot bugs that tests can't catch. That happens rarely unless the contributor is junion/not good.

[-] the_artic_one@programming.dev 1 points 1 year ago

If coders are good AND know the project

Those are some pretty big ifs.

[-] Blackthorn@programming.dev 1 points 1 year ago

Code review can't fix incompence though. I lost count of how many times my boss told me "review that PR well because X is not very good". Also my point is that they are overrated, not that they are useless.

load more comments (3 replies)
[-] null@slrpnk.net 1 points 1 year ago

The subtle Linux-flex in the screenshot.

load more comments
view more: ‹ prev next ›
this post was submitted on 14 Nov 2023
732 points (97.0% liked)

Programmer Humor

19623 readers
1 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS