43
you are viewing a single comment's thread
view the rest of the comments
[-] SpaceNoodle@lemmy.world 6 points 5 days ago

What's the alternative to being direct? Being indirect? Dropping hints? Spreading a rumor?

[-] pelya@lemmy.world 20 points 5 days ago

Being direct is good. But 'too complex, refactor' as an explanation is just one word longer than 'fuck off'. You need to explain in detail why the solution is bad and which parts should be changed, in this case it just shows that the reviewer did not actually read the code.

[-] SpaceNoodle@lemmy.world 17 points 5 days ago

The problem there is not the directness, but the terseness. This is something I had to learn myself, and fortunately was able to get feedback from colleagues who appreciated my directness and wanted more elaboration.

[-] Murvel@lemm.ee 4 points 5 days ago

Yes, being indirect. Instead of saying: 'you did a bad job', say 'here are things you can improve for next time'.

On is confrontational and problematic, the other diplomatic and constructive.

[-] SpaceNoodle@lemmy.world 3 points 5 days ago

You don't seem to understand what "direct" means.

"You did a bad job" is a subjective value statement that communicates nothing of value. It's direct, but also useless. The problem is not in the directness.

Providing immediate examples of improvements is also direct; the difference is that it's constructive, and helps guide the junior engineer.

[-] Murvel@lemm.ee -2 points 5 days ago

One is direct, and the other is not. And you're right, one is not constructive, and the other is, that's not coincidence.

What 'immediate' even means in this context I don't know.

[-] SpaceNoodle@lemmy.world 4 points 5 days ago

I just didn't want to have to say "direct" again.

this post was submitted on 29 Mar 2025
43 points (77.2% liked)

Programming

19301 readers
48 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities !webdev@programming.dev



founded 2 years ago
MODERATORS