Also spending millions on any politician is very likely gaining him more money than he invests. by a lot.

Not sure about that in Elon's unique case it's fucked over Tesla completely. However that's mostly his own doing with his nazi salute more than anything else, I think he'd be doing ok if he didn't do that.