321
me_irl (lemmy.eco.br)
you are viewing a single comment's thread
view the rest of the comments
[-] DieguiTux8623@feddit.it 23 points 1 year ago

The worst case is when someone requires changes, you address them, but then they disappear/go on a leave.

If the repository rules require all conversations to be resolved before merging and only the original reviewer can mark them as solved, the PR is stuck forever even if the rest of the team approves it.

[-] storcholus@feddit.de 9 points 1 year ago

That sounds like something you bring up in the retro

[-] DieguiTux8623@feddit.it 3 points 1 year ago

When the person came back from the leave I made some passive aggressive remark, hope this is enough 🤣

[-] ohlaph@lemmy.world 3 points 1 year ago

Have you tried ignoring their PRs for a few weeks?

[-] Blamemeta@lemm.ee 5 points 1 year ago

At that point, you get your team lead to go in the repo settings and unblock it.

[-] magic_lobster_party@kbin.social 1 points 1 year ago

Plot twist: it’s the team lead who goes on a leave

this post was submitted on 16 Nov 2023
321 points (98.8% liked)

Programmer Humor

19623 readers
1 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS