31

I was recently tasked with rewriting the base CSS for an inventory/project management system, creating a set of reusable components designed to match, using an open/close approach. These were based on a pretty strict specification provided by one of our designers, who unfortunately left.

The implementation went well, but I've run into a bit of a problem. Quite often the team members make changes directly to the base class in the new base CSS file, rather than extending it, creating a new one, or using each system area's dedicated stylesheet file.

One of the more recent changes involved removing a grid-gap property from a rule from the base CSS, affecting a lot more than the single UI element the team member was working on.

Should I approach the team about this?

I haven't mentioned anything yet, but have noticed our QA team putting in more bugs about UI elements looking odd

you are viewing a single comment's thread
view the rest of the comments
[-] Rokin@lemm.ee 10 points 10 months ago

I agree, code review is the proper solution here

[-] fidodo@lemmy.world 5 points 10 months ago

It's the best way to propagate coding culture.

Step 1: Get buy in. Discuss with the team and agree that it's a good idea. Write it down so there's a paper trail. Link to it in important base files in comments as a reminder as to what the guidelines are.

Step 2: Code review. Make sure the right people are required on code reviews for those base files. As the issues are brought up and fixed it will become a cultural habit and self propagate.

this post was submitted on 21 Jan 2024
31 points (100.0% liked)

Web Development

3430 readers
38 users here now

Welcome to the web development community! This is a place to post, discuss, get help about, etc. anything related to web development

What is web development?

Web development is the process of creating websites or web applications

Rules/Guidelines

Related Communities

Wormhole

Some webdev blogsNot sure what to post in here? Want some web development related things to read?

Heres a couple blogs that have web development related content

CreditsIcon base by Delapouite under CC BY 3.0 with modifications to add a gradient

founded 1 year ago
MODERATORS