301

True crime (europe.pub)

submitted 1 day ago by tfm@europe.pub to c/programmer_humor@programming.dev

63 comments fedilink hide all child comments

top 50 comments

sorted by: hot top controversial new old

[-] BigBenis@lemmy.world 3 points 17 hours ago

And what if it's undefined?

[-] tfm@europe.pub 2 points 9 hours ago

root access

[-] dohpaz42@lemmy.world 72 points 1 day ago

I mean aside of the variable name, this is not entirely unreasonable.

[-] grrgyle@slrpnk.net 6 points 1 day ago

The variable name is 90% why this is so unreasonable. Code is for humans to read, so names matter.

[-] shape_warrior_t@programming.dev 29 points 1 day ago

I would certainly rather see this than {isAdmin: bool; isLoggedIn: bool}. With boolean | null, at least illegal states are unrepresentable... even if the legal states are represented in an... interesting way.

[-] nialv7@lemmy.world 2 points 1 day ago

Admin false LoggedIn false doesn't feel illegal to me, more redundant if anything

[-] shape_warrior_t@programming.dev 6 points 1 day ago* (last edited 1 day ago)

I was thinking of the three legal states as:

not logged in (null or {isAdmin: false, isLoggedIn: false})
logged in as non-admin (false or {isAdmin: false, isLoggedIn: true})
logged in as admin (true or {isAdmin: true, isLoggedIn: true})

which leaves {isAdmin: true, isLoggedIn: false} as an invalid, nonsensical state. (How would you know the user's an admin if they're not logged in?) Of course, in a different context, all four states could potentially be distinctly meaningful.

[-] nialv7@lemmy.world 2 points 22 hours ago

ah you are right! i am so dumb.

[-] chocrates@piefed.world 1 points 21 hours ago

Honestly logged in is state and shouldn't be on the user object.

load more comments (13 replies)

[-] bhamlin@lemmy.world 51 points 1 day ago

Ah, the ol' tristate boolean switcheroo

[-] kionay@lemmy.world 3 points 18 hours ago* (last edited 3 hours ago)

tristate as in three states or tristate as in five states?

[-] bhamlin@lemmy.world 2 points 15 hours ago* (last edited 15 hours ago)

That is the jankiest thing I have seen in at least ten years.

Edit: because of course it's office.

[-] perviouslyiner@lemmy.world 3 points 18 hours ago

Is that a quantum boolean?

[-] bitjunkie@lemmy.world 3 points 1 day ago

You could make it even dumber by using weak comparisons.

[-] livingcoder@programming.dev 13 points 1 day ago

I see this every sprint.

[-] cupcakezealot@piefed.blahaj.zone 30 points 1 day ago

i would say why would you just not to isAdmin = true but i also worked with someone who did just this so i'll instead just sigh.

also the real crime is the use of javascript tbh

[-] Lemminary@lemmy.world 23 points 1 day ago

That's TypeScript. I can tell by the pixels defining a type above.

[-] Maiq@lemy.lol 6 points 1 day ago

Was looking at it and could not figure out why their weren't any semicolon's.

[-] ScintillatingStruthio@programming.dev 13 points 1 day ago

Neither Javascript nor Typescript require semicolon, it is entirely a stylistic choice except in very rare circumstances that do not come up in normal code.

[-] Lemminary@lemmy.world 13 points 1 day ago* (last edited 1 day ago)

Explanation for nerds

The reason is the JS compiler removes whitespace and introduces semicolons only "where necessary".

So writing

function myFn() {
  return true;
}

Is not the same as

function myFn() {
  return 
    true;
}

Because the compiler will see that and make it:

function myFn() { return; true; }

You big ol' nerd. Tee-hee.

[-] Ephera@lemmy.ml 9 points 1 day ago

That's terrifying, especially in JS where no type system will fuck you up for returning nothing when you should've returned a boolean.

[-] exu@feditown.com 5 points 1 day ago

Common JavaScript L

load more comments (1 replies)

load more comments (8 replies)

[-] tdawg@lemmy.world 26 points 1 day ago

This is pretty clearly just rage bait. Nothing is actually setting the value so it's undef. Moreover there isn't any context here to suggest if the state definitions are determined by some weird api or are actually just made up

[-] victorz@lemmy.world 8 points 1 day ago* (last edited 1 day ago)

Troof

I mean facts. Facts is what the kids say. Facts.

load more comments (3 replies)

[-] ramble81@lemmy.zip 13 points 1 day ago

Sadly this is (or used to be) valid in PHP and it made for some debugging “fun”.

[-] marcos@lemmy.world 9 points 1 day ago

There are several small details that PHP won't allow, but It's valid Javascript and it's the kind of thing you may find on that language.

[-] jbrains@sh.itjust.works 10 points 1 day ago

What if role is FILE_NOT_FOUND?!

[-] foxglove@lazysoci.al 15 points 1 day ago

if it's 'FILE_NOT_FOUND' then the string will be read as truthy and you will get 'User is admin' logged.

[-] bjoern_tantau@swg-empire.de 30 points 1 day ago

Ackshually three equal signs check for type as well. So mere truthiness is not enough. It has to be exactly true.

Also, everyone knows FILE_NOT_FOUND isn't a string but a boolean value.

[-] foxglove@lazysoci.al 1 points 22 hours ago

yeah, it's funny how my brain collapsed the boolean check into if (role) rather than if (role === true) - that's tricky

what is FILE_NOT_FOUND? I can't find much on it ...

[-] bjoern_tantau@swg-empire.de 3 points 22 hours ago

FILE_NOT_FOUND is from an old story on thedailywtf.com. Someone created a boolean enum with TRUE, FALSE and FILE_NOT_FOUND, if I recall correctly. It's been a recurring running joke.