And what if it's undefined
?
root access
I mean aside of the variable name, this is not entirely unreasonable.
The variable name is 90% why this is so unreasonable. Code is for humans to read, so names matter.
I would certainly rather see this than {isAdmin: bool; isLoggedIn: bool}
. With boolean | null
, at least illegal states are unrepresentable... even if the legal states are represented in an... interesting way.
Admin false LoggedIn false doesn't feel illegal to me, more redundant if anything
I was thinking of the three legal states as:
- not logged in (
null
or{isAdmin: false, isLoggedIn: false}
) - logged in as non-admin (
false
or{isAdmin: false, isLoggedIn: true}
) - logged in as admin (
true
or{isAdmin: true, isLoggedIn: true}
)
which leaves {isAdmin: true, isLoggedIn: false}
as an invalid, nonsensical state. (How would you know the user's an admin if they're not logged in?) Of course, in a different context, all four states could potentially be distinctly meaningful.
ah you are right! i am so dumb.
Honestly logged in is state and shouldn't be on the user object.
Ah, the ol' tristate boolean switcheroo
Classic checkbox values
Yup. Checked, unchecked, and not checked.
tristate as in three states or tristate as in five states?
That is the jankiest thing I have seen in at least ten years.
Edit: because of course it's office.
Is that a quantum boolean?
I see this every sprint.
i would say why would you just not to isAdmin = true
but i also worked with someone who did just this so i'll instead just sigh.
also the real crime is the use of javascript tbh
You could make it even dumber by using weak comparisons.
This is pretty clearly just rage bait. Nothing is actually setting the value so it's undef. Moreover there isn't any context here to suggest if the state definitions are determined by some weird api or are actually just made up
Sadly this is (or used to be) valid in PHP and it made for some debugging โfunโ.
There are several small details that PHP won't allow, but It's valid Javascript and it's the kind of thing you may find on that language.
What if role
is FILE_NOT_FOUND
?!
if it's 'FILE_NOT_FOUND'
then the string will be read as truthy and you will get 'User is admin'
logged.
Ackshually three equal signs check for type as well. So mere truthiness is not enough. It has to be exactly true.
Also, everyone knows FILE_NOT_FOUND isn't a string but a boolean value.
yeah, it's funny how my brain collapsed the boolean check into if (role)
rather than if (role === true)
- that's tricky
what is FILE_NOT_FOUND
? I can't find much on it ...
FILE_NOT_FOUND is from an old story on thedailywtf.com. Someone created a boolean enum with TRUE, FALSE and FILE_NOT_FOUND, if I recall correctly. It's been a recurring running joke.
thank you for letting me in on the joke ๐
and for catching my error!
Welcome! I guess this is your Ten Thousand moment for a mediocre joke for old programmers. ๐ช๐
haha, yes - exactly! At least I got that reference, xkcd is pretty well known, though.
I see that they've gone back to the name "The Daily WTF". For some time, they changed to "Worse than failure" in order to avoid not even the word "fuck". ๐คท
Programmer Humor
Welcome to Programmer Humor!
This is a place where you can post jokes, memes, humor, etc. related to programming!
For sharing awful code theres also Programming Horror.
Rules
- Keep content in english
- No advertisements
- Posts must be related to programming or programmer topics