Edinburgh may be my favorite city I've ever visited. I want to go back again later this year. That being said: thoughts about some of the things we did.

Edinburgh Castle is iconic, has great views, and outside of the Scottish crown jewels it was not that terribly crowded though there is also not as much to see as something like the tower of London though the history is still quite interesting. Can probably see it all in under a half day, realistically I think we were there four hours and saw everything but the crown jewels.

The royal botanic gardens in Edinburgh was not on my list of things to do before visiting but it was beautiful. Would definitely book at least half a day to explore it.

The johnny walker experience wasn't all that great. Would book a seat at their bar way early but the tasting wasn't particularly special. The west end brasserie right across the street from there actually has a stupidly long scotch menu if you have an idea of what styles you already like and just want to go taste a broad variety of things you could probably have actually spent less money there for better scotch (I don't particularly love most of JW's blends).

We actually took a fly fishing trip for native brown trout on one of the lochs northeast of Glasgow. VERY reasonably priced, gorgeous scenery, and fun letting my (now) wife catch her first trout on a fly. Pun intended but she's now hooked. Definitely needed to pack better waterproof gear for that though. The rain jacket wasn't good enough sitting in a boat going across a loch in a strong mist.