It’s definitely this one. Design 2 confuses me, but I am quite dumb so maybe that’s just me lol.
Going by the votes you are certainly not alone
I guess the community has spoken, I'll update the PR accordingly ✌🏻
A single visual clue should be linked to a single behaviour. Design 2 has two visual clues for one thing (filled heart and crossed out), that's one too much.
I'd much rather prefer consistent design with the rest of the app. This would mean a possible Design 3: Stroked heart, no filling, and crossed out when the button will unsubscribe you
Design 3 would be consistent with but not with
Also it brings to fore a wider debate. Should that button denote the current status or should it denote the action that will happen on pressing the button.
A favourite is not a subscription, right? Although, I've got to agree with you that a consistent style across favourites and subscriptions would be nice
No they aren't the same. I just thought the design would be more consistent as both of them are options living outside the ellipsis menu.
Also I edited my comment above. Care to weigh in on the discussion there¿?
Reading the Apple Human Interface Guideline, it states the following:
If you use a button that behaves like a toggle, you generally use an interface icon that communicates its purpose, and you update its appearance — typically by changing the background — based on the current state.
So Design 1 lays closest to best practice. Regarding the ellipsis menu, I'm not sure what to do there. I'd really like a consistent approach, but a stroke-and-filled state might lead to more confusion than what's there currently. I'm all in on your Design 1 right now.
It is not my design. I just gave some inputs. All credits for the design and the pull request go to https://github.com/sharunkumar
Voyager
The official lemmy community for Voyager, an open source, mobile-first client for lemmy.
Rules
- Be nice.
- lemmy.world instance policy
Sponsor development! 👇
💙