790

Better merge it, too! (i.imgflip.com)

submitted 10 months ago by superkret@feddit.org to c/programmer_humor@programming.dev

42 comments fedilink hide all child comments

top 42 comments

sorted by: hot top controversial new old

[-] mspencer712@programming.dev 90 points 10 months ago

Remove these blank lines.

I’m not seeing unit tests for this.

Unnecessary comment.

BLAM

Ow! Also, this could’ve been a smaller calibur.

[-] sebsch@discuss.tchncs.de 1 points 10 months ago

The second one is very valid. Please do not waste my time without having a prove about your functionality.

[-] zero_spelled_with_an_ecks@programming.dev 57 points 10 months ago

LGTM (lunatic gunner targeting me)

[-] thoughtfuldragon@lemmy.blahaj.zone 9 points 10 months ago

it's me I'm lunatic gunner

[-] steventhedev@lemmy.world 43 points 10 months ago

I have either written or gotten a variant of every single one of these comments 🫠:

Please include the JIRA task in the commit title.

Did you run any manual testing?

Where's the PRD link in the commit message?

Can you please split this into multiple smaller commits?

Can you combine these two commits?

Did you email Jon about this because he's working on that project with Sarah and you might be duplicating efforts.

This should be named BarFoo instead of FooBar.

Why aren't you using CorporateInternalLib16 that does 90% of this?

Why aren't you using ThirdPartyPaidLibByExEmployee?

Why aren't you using StandardLib thing you forgot existed?

All our I/O should be async.

All our hot loop code needs to be sync.

This will increase latency of NonCoreBusinessFlow by 0.01%. can you shave some time off so we can push in feature B also?

Please add a feature flag so we can do gradual rollout.

What operational levers does this have?

Lgtm - just address those comments

[-] expr@programming.dev 26 points 10 months ago

I dunno, plenty of those sound pretty reasonable.

[-] frezik@midwest.social 3 points 10 months ago

Mostly, yes.

I'd like to find a better way to phrase "why aren't you . . . " questions. It carries an accusatory tone in text, even if you don't intend that. The answer is almost invariably going to be either "I didn't know it existed" or "because reason X". Neither case justifies the accusatory tone. Maybe if the "I didn't know it existed" answer was something so basic that they really should have known it existed, but probably not even then.

[-] LPThinker@lemmy.world 3 points 10 months ago

My preferred variation of this is to make it an open question that leaves them in the position of authority, and assumes that they made a deliberate decision.

For example, instead of "Why aren't you using StandardLib that does 90% of this?", I would try "Could this be achieved with StandardLib? Seems like it would cover 90% of this".

[-] skulbuny@sh.itjust.works 3 points 10 months ago

If you have seniority and they are a junior, some juniors do respond well to a senior having more knowledge about the codebase. With them, it can be beneficial to use a tone like "We have library X that seems like it could do a lot of the functionality here, unless you already took a look?" I know it's like 90% of the same but I know people who will just be shellshocked and just blindly say "yes" to any question you ask them, and I don't want a blind "yes" I wanna know the truth :) it also lets then explain why they didn't use it if they have a legit reason because hey, maybe I'm the one who needs to be caught up

[-] Hammerheart@programming.dev 25 points 10 months ago

lgtm

[-] superkret@feddit.org 23 points 10 months ago

lunatic girl threatening me

[-] Rob@lemmy.world 7 points 10 months ago

Let’s gamble, try merging

[-] savvywolf@pawb.social 22 points 10 months ago

"Did you run the formatter on this?"

Bonus points if it's python code and nowhere in the docs does it say which of the many formatters to use.

[-] bob_lemon@feddit.org 4 points 10 months ago

Just make another PR where you add formatter instructions to the readme and pyproject.toml.

[-] eager_eagle@lemmy.world 1 points 7 months ago

add it as a pre-commit hook, so no one has to remember to run it

[-] GammaGames@beehaw.org 2 points 10 months ago* (last edited 10 months ago)

Use black and pray

[-] bob_lemon@feddit.org 5 points 10 months ago

I'm fond of ruff lately. Pretty much the same as black, but it just comes with the linter instead of being separate tools.

[-] GammaGames@beehaw.org 2 points 10 months ago* (last edited 10 months ago)

👀 I’d fine-tuned (copied and pasted) a pylint setup that had some of black, what are the differences?

Edit: it’s so much faster than black, I’m switching

Edit2: used it today, faster and I like the linter. It also does some multi-line parentheses better imo

[-] AnarchoSnowPlow@midwest.social 19 points 10 months ago

Just pull the trigger, we both know how this ends.

[-] zero_spelled_with_an_ecks@programming.dev 4 points 10 months ago

Production errors.

[-] henfredemars@infosec.pub 17 points 10 months ago

The number of comments is inversely proportional to the size of the pull request.

[-] Opisek@lemmy.world 5 points 10 months ago

Yet the review time is exponential with the size.

[-] ZILtoid1991@lemmy.world 8 points 10 months ago

https://github.com/ZILtoid1991

Please, do pull requests on my projects! I might even accept them.

[-] lesnout27@feddit.org 8 points 10 months ago

You realy want the D don't you

[-] leds@feddit.dk 6 points 10 months ago

The Diff?

[-] lesnout27@feddit.org 4 points 10 months ago* (last edited 10 months ago)

All repos on the linked github account are written in D

[-] ZILtoid1991@lemmy.world 6 points 10 months ago

gigachad_yes.gif

[-] ngn@lemy.lol 7 points 10 months ago

i don't understand it, am i missing some context here?

[-] pixelscript@lemm.ee 25 points 10 months ago

The meme format implies she catfished you with the promise of "Netflix and chill" at her house only to pull a gun on you.

In particular, she wants you to review and merge that goddamn pull request she made to your open source project repo two months ago that finally fixes that one really annoying bug.

[-] grrgyle@slrpnk.net 6 points 10 months ago

Look at that tiny numstat, I'll finish the review before the CI is even done

[-] Midnitte@beehaw.org 5 points 10 months ago

Takes on a slightly different meaning in the context of XZ utils

[-] whoisearth@lemmy.ca 5 points 10 months ago

First problem is she's expecting a right boob like me to review her pull request. Second problem is I don't give a shit.

[-] half_built_pyramids@lemmy.world 4 points 10 months ago

Babe, you turn me (O)n

[-] rambling_lunatic@sh.itjust.works 4 points 10 months ago

What is the original source material for the image and the name of the woman within?

[-] Klear@lemmy.world 10 points 10 months ago* (last edited 10 months ago)

This is the artist, if you can excuse a link to X which I found on reddit via google.

...

I feel dirty.

Edit: Here's a KYM article. No idea why I didn't find it on my first sweep. It might have something to do with google being absolute dogshit these days.