If your phone can survive until next summer it might be a good idea, EU is forcing some consumer friendly requirements which I imagine will give you a wider availability of models with five years of updates.
https://energy-efficient-products.ec.europa.eu/product-list/smartphones-and-tablets_en

Ecodesign requirements will apply to mobile phones and tablets put on the EU market from 20 June 2025 onwards, including:

1. resistance to accidental drops or scratches and protection from dust and water
2. sufficiently durable batteries which can withstand at least 800 charge and discharge cycles while retaining at least 80% of their initial capacity
3. rules on disassembly and repair, including obligations for producers to make critical spare parts available within 5-10 working days, and for 7 years after the end of sales of the product model on the EU market
4. availability of operating system upgrades for longer periods (at least 5 years from the date of the end of placement on the market of the last unit of a product model)
5. non-discriminatory access for professional repairers to any software or firmware needed for the replacement

If you can wait until Black Friday, Pixels always have significant sales.

Pixel goes on seriously steep sale in holiday season. If you are in the U.S. and you think the price is right, you can wait for that.

last year: https://www.cnet.com/deals/black-friday-pixel-sale-takes-up-to-25-off-unlocked-google-phones/

I personally will take the pixel over oneplus, just because I like the android aesthetics and like to keep the possibility of modding open.

I switched from Samsung to Pixel and I'm on my second Pixel phone now and they're great. So much better OS and smoother than OneUI ever was.

I'm looking to upgrade my phone as well. One important thing I want is call recording, and that really narrows the options.

Samsung phones can record calls, but you need to use SamFW to change the CSC. LineageOS does not support recent models.

OnePlus phones have better hardware specs, but I think nowadays you have to root with Magisk and use BCR for recording. That breaks banking apps. LineageOS supports some OnePlus models, but not 12.

Pixels don't have native call recording? But GrapheneOS works on them. Again, many apps are broken.

Fairphone might be interesting, I should look into that.

Of you don't want custom ROM than buy whatever you want. But if you want privacy you need an pixel phone because they support graphen os.

I'm currently using a Nothing Phone 2 and i really like it.