7
Thunderbolt USB hub
(sh.itjust.works)
I think to present rules like this as hard rules, with little explanation and no nuance is harmful to less experienced engineers.
A prime example here is the Duplicated Code one. Which takes an absolute approach to code duplication, even when the book that is referenced highlights the Rule of Three:
The Rule of Three
Here’s a guideline Don Roberts gave me: The first time you do something,
you just do it. The second time you do something similar, you wince at the
duplication, but you do the duplicate thing anyway. The third time you do
something similar, you refactor.
Or for those who like baseball: Three strikes, then you refactor.
I've seen more junior devs bend over backwards, make their code worse and take twice as long to adhere to some rules that are really more what you'd call guidelines than actual rules.
Sure, try to avoid code duplication, but sometimes duplicating code is better than the wrangling you'd need to do to remove it.
Making extra changes also leaves extra room for bugs to creep in. So now you need to test the place you were working, and anywhere else you touched because of the refactoring.
:strip_icc()/pic4312014.jpg){kind=link}
The site doesn’t define what a code smell is, though. It’s just a list of Don’t Do’s.
That’s kind of the nuance I would be hoping for.
Something like:
(The rule of 3 formatting was intentional, given the community we’re in)